Extract hardcoded homepage strings to locale files (Fixes #3802)#3950
Open
ablzh wants to merge 4 commits into
Open
Extract hardcoded homepage strings to locale files (Fixes #3802)#3950ablzh wants to merge 4 commits into
ablzh wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #3802 by extracting the remaining hardcoded English strings on the homepage into the locale system, enabling full localization for non-English users.
Specifically, the following strings were extracted to _data/locales/home/en.yml:
Implementation Details & Fallback Mechanism
To avoid breaking the homepage for languages that do not yet have these translations, I implemented a strict string-level English fallback using the Liquid default filter:
Instructions for Locale Maintainers
Other language maintainers do not need to do anything immediately; their pages will continue to display the English strings safely.
To localize these strings for your language, simply add the following keys to your respective _data/locales/home/*.yml file: