feat(dind): support configure env vars on private-docker-registry container#881
Merged
Conversation
3 tasks
…container Adds `privateDockerRegistry.env` (map, same pattern as `executor.env`) so operators can configure the distribution registry via environment variables without patching the chart. Includes a documented example for proxying an internal private registry with credentials. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
michaellzc
force-pushed
the
mlin/private-registry-env
branch
from
1647808 to
2c660b4
Compare
michaellzc
changed the title
devdinu
approved these changes
Jun 6, 2026
marcleblanc2
approved these changes
Jun 6, 2026
DaedalusG
approved these changes
Jun 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
privateDockerRegistry.env(map keyed by env var name, same pattern asexecutor.env) so operators can configure the distribution registry via environment variables without patching the chartREGISTRY_PROXY_REMOTEURLin the template with a default entry invalues.yaml, making it overridableREGISTRY_<SECTION>_<KEY>convention with a link to the upstream distribution config reference and a concrete example for proxying an internal private registry with credentialsTest plan
helm templaterenders theREGISTRY_PROXY_REMOTEURLenv var by defaultprivateDockerRegistry.env(plainvalue:andvalueFrom: secretKeyRef:) renders correctly in the StatefulSet🤖 Generated with Claude Code